linux-kernel - Re: [PATCH -next] drm/amdkfd: clean up some inconsistent indentings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4caa8083-017f-034e-55cf-321ad1a7ba44@amd.com>
Date:   Tue, 25 Oct 2022 15:42:47 -0400
From:   Felix Kuehling <felix.kuehling@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, alexander.deucher@....com
Cc:     christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
        daniel@...ll.ch, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] drm/amdkfd: clean up some inconsistent indentings

Am 2022-10-25 um 02:09 schrieb Yang Li:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:331 svm_migrate_copy_to_vram() warn: inconsistent indenting
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2537
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

This patch doesn't apply to our amd-staging-drm-next, nor to the 
kernel.org master branch. Which branch is this against?

Thanks,
   Felix


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index 20d6b2578927..cddf259875c0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -328,8 +328,7 @@ svm_migrate_copy_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
>   
>   		dst[i] = cursor.start + (j << PAGE_SHIFT);
>   		migrate->dst[i] = svm_migrate_addr_to_pfn(adev, dst[i]);
> -			svm_migrate_get_vram_page(&kfddev->pgmap, prange,
> -						  migrate->dst[i]);
> +		svm_migrate_get_vram_page(&kfddev->pgmap, prange, migrate->dst[i]);
>   		migrate->dst[i] = migrate_pfn(migrate->dst[i]);
>   
>   		spage = migrate_pfn_to_page(migrate->src[i]);