linux-kernel - Re: [PATCH v2 04/11] thermal: k3_j72xx_bandgap: map fuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221025194201.3iup4ionv3zhnfd5@bryanbrattlof.com>
Date:   Tue, 25 Oct 2022 14:42:01 -0500
From:   Bryan Brattlof <bb@...com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
CC:     Keerthy <j-keerthy@...com>, Linux PM <linux-pm@...r.kernel.org>,
        Device Trees <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        LKML ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 04/11] thermal: k3_j72xx_bandgap: map fuse_base only
 for erratum workaround

On October 25, 2022 thus sayeth Bryan Brattlof:
> Some of TI's J721E SoCs require a software trimming procedure for the
> temperature monitors to function properly. To determine if a particular
> J721E is not affected by this erratum, both bits in the WKUP_SPARE_FUSE0
> region must be set. Other SoCs, not affected by this erratum, will not
> need this region.
> 
> Map the 'fuse_base' region only when the erratum fix is needed.
> 
> Signed-off-by: Bryan Brattlof <bb@...com>
> ---
>  drivers/thermal/k3_j72xx_bandgap.c | 37 ++++++++++++++++++------------
>  1 file changed, 22 insertions(+), 15 deletions(-)
> 

...

>  
> -	if (workaround_needed)
> -		devm_iounmap(dev, fuse_base);
> -

Ugh... This is wrong. 

Of course I will catch it right after I send this out

Sorry for the noise everyone
~Bryan