linux-kernel - Re: [PATCH] lib/string.c: Improve strcasecmp speed by not lowering if chars match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cad4345a-9a51-34ca-b599-f8f98db40200@nathanm.com>
Date:   Tue, 25 Oct 2022 22:37:27 +0000
From:   Nathan Moinvaziri <nathan@...hanm.com>
To:     Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH] lib/string.c: Improve strcasecmp speed by not lowering if
 chars match

On 10/25/2022 12:55 PM, Rasmus Villemoes wrote:
> Are there any code paths in the kernel where strcasecmp performance
> matters? strcmp, sure, but strcasecmp or strncasecmp? I don't think so.
> If anything, we should nuke the complication in strncasecmp(), and then
> make strcasecmp() simply do strncasecmp(a, b, SIZE_MAX).

It looks like several of the string functions could be collapsed in that 
way.

Nathan