[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221025170346.2fbd0158e98882dd09812431@kernel.org>
Date: Tue, 25 Oct 2022 17:03:46 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Rafael Mendonca <rafaelmendsr@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
Alexei Starovoitov <ast@...nel.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fprobe: Check rethook_alloc() return in rethook
initialization
On Tue, 25 Oct 2022 00:12:08 -0300
Rafael Mendonca <rafaelmendsr@...il.com> wrote:
> Check if fp->rethook succeeded to be allocated. Otherwise, if
> rethook_alloc() fails, then we end up dereferencing a NULL pointer in
> rethook_add_node().
Good catch!
Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Thank you!
>
> Fixes: 5b0ab78998e3 ("fprobe: Add exit_handler support")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@...il.com>
> ---
> kernel/trace/fprobe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> index aac63ca9c3d1..71614b2a67ff 100644
> --- a/kernel/trace/fprobe.c
> +++ b/kernel/trace/fprobe.c
> @@ -141,6 +141,8 @@ static int fprobe_init_rethook(struct fprobe *fp, int num)
> return -E2BIG;
>
> fp->rethook = rethook_alloc((void *)fp, fprobe_exit_handler);
> + if (!fp->rethook)
> + return -ENOMEM;
> for (i = 0; i < size; i++) {
> struct fprobe_rethook_node *node;
>
> --
> 2.34.1
>
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists