linux-kernel - Re: [PATCH] fprobe: Check rethook_alloc() return in rethook initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221025074754.0e66cd76@gandalf.local.home>
Date:   Tue, 25 Oct 2022 07:47:54 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Rafael Mendonca <rafaelmendsr@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fprobe: Check rethook_alloc() return in rethook
 initialization

On Tue, 25 Oct 2022 17:03:46 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Tue, 25 Oct 2022 00:12:08 -0300
> Rafael Mendonca <rafaelmendsr@...il.com> wrote:
> 
> > Check if fp->rethook succeeded to be allocated. Otherwise, if
> > rethook_alloc() fails, then we end up dereferencing a NULL pointer in
> > rethook_add_node().  
> 
> Good catch!
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Masami, feel free to pull this in.

-- Steve