linux-kernel - [PATCH] drm/tests: Add back seed value information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2022 18:14:58 -0300
From:   Arthur Grillo <arthurgrillo@...eup.net>
To:     David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Maíra Canal <mairacanal@...eup.net>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>, andrealmeid@...eup.net,
        melissa.srw@...il.com, Arthur Grillo <arthurgrillo@...eup.net>,
        Michał Winiarski <michal.winiarski@...el.com>
Subject: [PATCH] drm/tests: Add back seed value information

As reported by Michał the drm_mm and drm_buddy unit tests lost the
printk with seed value after they being refactored into kunit. This
patch adds back this important information to assure reproducibility
converting them to use the kunit api.

Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
Reported-by: Michał Winiarski <michal.winiarski@...el.com>
---
 drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
 drivers/gpu/drm/tests/drm_mm_test.c    | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
index 62f69589a72d..83c8863bc643 100644
--- a/drivers/gpu/drm/tests/drm_buddy_test.c
+++ b/drivers/gpu/drm/tests/drm_buddy_test.c
@@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test)
 	while (!random_seed)
 		random_seed = get_random_u32();
 
+	kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
+		random_seed);
+
 	return 0;
 }
 
diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
index c4b66eeae203..492347069d58 100644
--- a/drivers/gpu/drm/tests/drm_mm_test.c
+++ b/drivers/gpu/drm/tests/drm_mm_test.c
@@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test)
 	while (!random_seed)
 		random_seed = get_random_u32();
 
+	kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
+	random_seed, max_iterations, max_prime);
+
 	return 0;
 }
 
@@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = {
 };
 
 kunit_test_suite(drm_mm_test_suite);
-
 MODULE_AUTHOR("Intel Corporation");
 MODULE_LICENSE("GPL");
-- 
2.37.3