linux-kernel - Re: [PATCH] drm/tests: Add back seed value information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bd861cb-1eae-7f02-719b-8babfe7185dc@riseup.net>
Date:   Wed, 26 Oct 2022 18:34:41 -0300
From:   Maíra Canal <mairacanal@...eup.net>
To:     Arthur Grillo <arthurgrillo@...eup.net>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>, andrealmeid@...eup.net,
        melissa.srw@...il.com,
        Michał Winiarski <michal.winiarski@...el.com>
Subject: Re: [PATCH] drm/tests: Add back seed value information

Hi Arthur,

On 10/26/22 18:14, Arthur Grillo wrote:
> As reported by Michał the drm_mm and drm_buddy unit tests lost the
> printk with seed value after they being refactored into kunit. This

Some grammar nits:
- s/being/were
- s/kunit/KUnit

> patch adds back this important information to assure reproducibility
> converting them to use the kunit api.
> 
> Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
> Reported-by: Michał Winiarski <michal.winiarski@...el.com>

I believe that Michał's should come before your tag, as the SoB chain
should reflect the real route a patch took as it was propagated to the
maintainers [1].

> ---
>  drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
>  drivers/gpu/drm/tests/drm_mm_test.c    | 4 +++-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 62f69589a72d..83c8863bc643 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test)
>  	while (!random_seed)
>  		random_seed = get_random_u32();
>  
> +	kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
> +		random_seed);

I'm getting some compiling errors here:

ERROR:root:../drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error:
expected ')'
                random_seed);
                ^
../drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
        kunit_info("Testing DRM buddy manager (struct drm_buddy), with
random_seed=0x%x\n",
        ^

You can reproduce it by running:

$ ./tools/testing/kunit/kunit.py --kunitconfig=drivers/gpu/drm/tests

Moreover, could you address the checkpatch issues? There are some
misaligned parenthesis and the line are too big.

> +
>  	return 0;
>  }
>  
> diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
> index c4b66eeae203..492347069d58 100644
> --- a/drivers/gpu/drm/tests/drm_mm_test.c
> +++ b/drivers/gpu/drm/tests/drm_mm_test.c
> @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test)
>  	while (!random_seed)
>  		random_seed = get_random_u32();
>  
> +	kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
> +	random_seed, max_iterations, max_prime);
> +

Same here.

>  	return 0;
>  }
>  
> @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = {
>  };
>  
>  kunit_test_suite(drm_mm_test_suite);
> -

There is no need to change this line.

Thanks for your patch!

[1]
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Best Regards,
- Maíra Canal


>  MODULE_AUTHOR("Intel Corporation");
>  MODULE_LICENSE("GPL");