linux-kernel - Re: [PATCH v4 2/4] kvm: Add KVM_PFN_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1m5J2+6AcYHUf4P@google.com>
Date:   Wed, 26 Oct 2022 22:48:07 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        John Hubbard <jhubbard@...dia.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        David Matlack <dmatlack@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Linux MM Mailing List <linux-mm@...ck.org>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH v4 2/4] kvm: Add KVM_PFN_ERR_SIGPENDING

Uber nit, s/kvm/KVM for the shortlog,

On Tue, Oct 11, 2022, Peter Xu wrote:
> Add a new pfn error to show that we've got a pending signal to handle

Please avoid pronouns in changelogs and comments, they're unnecessarily ambiguous.
E.g. 

  Add a new pfn error to capture that hva_to_pfn_slow() failed due to a
  pending signal.  The new error will be used in future patches to
  propagate -EINTR back to userspace instead of returning -EFAULT.
 

> during hva_to_pfn_slow() procedure (of -EINTR retval).
> 
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---

Nits aside,

Reviewed-by: Sean Christopherson <seanjc@...gle.com>