linux-kernel - Re: [PATCH] perf auxtrace: Fix address filter symbol name match for modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1k9qwNKy/fJVjn1@kernel.org>
Date:   Wed, 26 Oct 2022 11:01:15 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf auxtrace: Fix address filter symbol name match for
 modules

Em Wed, Oct 26, 2022 at 10:27:36AM +0300, Adrian Hunter escreveu:
> For modules, names from kallsyms__parse() contain the module name which
> meant that module symbols did not match exactly by name.
> 
> Fix by matching the name string up to the separating tab character.

Thanks, applied.

- Arnaldo

 
> Fixes: 1b36c03e3569 ("perf record: Add support for using symbols in address filters")
> Cc: stable@...r.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/util/auxtrace.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index b59c278fe9ed..c50eb2bfc518 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -2321,11 +2321,19 @@ struct sym_args {
>  	bool		near;
>  };
>  
> +static bool kern_sym_name_match(const char *kname, const char *name)
> +{
> +	size_t n = strlen(name);
> +
> +	return !strcmp(kname, name) ||
> +	       (!strncmp(kname, name, n) && kname[n] == '\t');
> +}
> +
>  static bool kern_sym_match(struct sym_args *args, const char *name, char type)
>  {
>  	/* A function with the same name, and global or the n'th found or any */
>  	return kallsyms__is_function(type) &&
> -	       !strcmp(name, args->name) &&
> +	       kern_sym_name_match(name, args->name) &&
>  	       ((args->global && isupper(type)) ||
>  		(args->selected && ++(args->cnt) == args->idx) ||
>  		(!args->global && !args->selected));
> -- 
> 2.34.1

-- 

- Arnaldo