linux-kernel - Re: [PATCH stable 4.19] arm64: errata: Remove AES hwcap for COMPAT tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1loP4wJEgBdZvL3@kroah.com>
Date:   Wed, 26 Oct 2022 19:02:55 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     stable@...r.kernel.org, James Morse <james.morse@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Jonathan Corbet <corbet@....net>,
        Zenghui Yu <yuzenghui@...wei.com>,
        Ionela Voinescu <ionela.voinescu@....com>,
        Shreyas K K <quic_shrekk@...cinc.com>,
        Marc Zyngier <maz@...nel.org>, Joey Gouly <joey.gouly@....com>,
        Reiji Watanabe <reijiw@...gle.com>,
        Alexandru Elisei <alexandru.elisei@....com>,
        "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH stable 4.19] arm64: errata: Remove AES hwcap for COMPAT
 tasks

On Wed, Oct 26, 2022 at 09:51:20AM -0700, Florian Fainelli wrote:
> 
> 
> On 10/26/2022 9:49 AM, Greg Kroah-Hartman wrote:
> > On Thu, Oct 20, 2022 at 04:01:07PM -0700, Florian Fainelli wrote:
> > > From: James Morse <james.morse@....com>
> > > 
> > > commit 44b3834b2eed595af07021b1c64e6f9bc396398b upstream
> > > 
> > > Cortex-A57 and Cortex-A72 have an erratum where an interrupt that
> > > occurs between a pair of AES instructions in aarch32 mode may corrupt
> > > the ELR. The task will subsequently produce the wrong AES result.
> > > 
> > > The AES instructions are part of the cryptographic extensions, which are
> > > optional. User-space software will detect the support for these
> > > instructions from the hwcaps. If the platform doesn't support these
> > > instructions a software implementation should be used.
> > > 
> > > Remove the hwcap bits on affected parts to indicate user-space should
> > > not use the AES instructions.
> > > 
> > > Acked-by: Ard Biesheuvel <ardb@...nel.org>
> > > Signed-off-by: James Morse <james.morse@....com>
> > > Link: https://lore.kernel.org/r/20220714161523.279570-3-james.morse@arm.com
> > > Signed-off-by: Will Deacon <will@...nel.org>
> > > [florian: resolved conflicts in arch/arm64/tools/cpucaps and cpu_errata.c]
> > > Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> > > Change-Id: I651a0db2e9d2f304d210ae979ae586e7dcc9744d
> > 
> > No need for Change-Id: in upstream patches :)
> 
> Meh, the perils of working with Gerrit in the same tree.. do you need me to
> resubmit or can you strip those when you apply the patches?

I stripped them all, no worries.