linux-kernel - Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad965dad-ced7-4f10-13fb-2d30e058f428@gmail.com>
Date:   Wed, 26 Oct 2022 20:21:53 +0300
From:   Péter Ujfalusi <peter.ujfalusi@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     vkoul@...nel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] dmaengine: ti: edma: Remove the unused function
 edma_and()



On 18/10/2022 11:38, Jiapeng Chong wrote:
> The function edma_and() is defined in the edma.c file, but not called
> elsewhere, so remove this unused function.
> 
> drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.

0f4c5b29e333 dmaengine: ti: edma: Remove some unused functions
dropped edma_param_and() but left the edma_and() behind...

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>

> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/dma/ti/edma.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index fa06d7e6d8e3..9ea91c640c32 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
>   	edma_write(ecc, offset, val);
>   }
>   
> -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> -{
> -	unsigned val = edma_read(ecc, offset);
> -
> -	val &= and;
> -	edma_write(ecc, offset, val);
> -}
> -
>   static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
>   {
>   	unsigned val = edma_read(ecc, offset);

-- 
Péter