linux-kernel - Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 09:49:48 -0700
From:   Justin Chen <justinpopo6@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@...ts.infradead.org>
Subject: Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()

On Wed, Oct 26, 2022 at 3:45 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Justin Chen <justinpopo6@...il.com>

> ---
>  drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
> index 2cb3779fcdf8..fbf454b206f2 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb.c
> @@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
>                 priv->suspend_clk = NULL;
>         }
>
> -       priv->wake_irq = platform_get_irq_byname(pdev, "wake");
> +       priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
>         if (priv->wake_irq < 0)
> -               priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
> +               priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
>         if (priv->wake_irq >= 0) {
>                 err = devm_request_irq(dev, priv->wake_irq,
>                                        brcm_usb_phy_wake_isr, 0,
> --
> 2.25.1
>