linux-kernel - Re: [tip:x86/core] [kallsyms] f138918162: WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1q2/fdvXI67MRch@hirez.programming.kicks-ass.net>
Date:   Thu, 27 Oct 2022 18:51:09 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     Yujie Liu <yujie.liu@...el.com>, oe-lkp@...ts.linux.dev,
        lkp@...el.com, Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        fengwei.yin@...el.com, ying.huang@...el.com,
        fstests@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [tip:x86/core] [kallsyms] f138918162:
 WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert_ratelimited.cold-#[xfs]


> However, I noticed that the callsite in the WARNING: message has changed
> from the usual 'asswarn' (which is the caller of WARN_ON) to
> 'xfs_buf_alert_ratelimited', which seems totally wrong since XFS log
> recovery doesn't touch xfs_buf objects at all.

Yeah; and I've meanwhile found more cases where it goes sideways.

I'll revert this patch and try an alternative approach. I'll post
patches tomorrow or something.

Sorry about this.