[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <050ab042-d51c-1e9a-eb85-8fbec8020211@huawei.com>
Date: Thu, 27 Oct 2022 15:47:48 +0800
From: chenweilong <chenweilong@...wei.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
<f.fangjian@...wei.com>, <linus.walleij@...aro.org>,
<yangyicong@...ilicon.com>, <xuwei5@...wei.com>,
<robh+dt@...nel.org>, <robh@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>
CC: <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>
Subject: Re: [PATCH next 2/2] dt-bindings: gpio: add entry for
hisilicon,gpio-ascend910
On 2022/10/26 22:46, Krzysztof Kozlowski wrote:
> On 25/10/2022 23:42, Weilong Chen wrote:
>> Add the new compatible for HiSilicon gpio controller driver.
>>
>> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
>> ---
>> .../gpio/hisilicon,gpio-ascend910.yaml | 54 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 55 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml b/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
>> new file mode 100644
>> index 000000000000..912e4b808cae
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/hisilicon,gpio-ascend910.yaml
>> @@ -0,0 +1,54 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpio/hisilicon,gpio-ascend910.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: HiSilicon common GPIO controller Device Tree Bindings
> Drop "Device Tree Bindings"
>
>> +
>> +maintainers:
>> + - Jay Fang <f.fangjian@...wei.com>
>> +
>> +properties:
>> + compatible:
>> + const: hisilicon,gpio-ascend910
>> + description:
>> + The HiSilicon common GPIO controller can be used for many different
>> + types of SoC such as Huawei Ascend AI series chips.
> Put this description in top-level description.
>
>> +
>> + reg:
>> + description:
>> + Address and length of the register set for the device.
> Drop description.
>
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + gpio-controller: true
>> +
>> + "#gpio-cells":
>> + const: 2
>> +
>> + ngpios:
>> + minimum: 1
>> + maximum: 32
>> +
>> +required:
>> + - compatible
>> + - gpio-controller
> gpio-cells are not required?
>
>> + - reg
>> + - interrupts
>> + - ngpios
>> +
>> +unevaluatedProperties: false
> Instead:
> additionalProperties: false
>
>> +
>> +examples:
>> + - |
>> + gpio@...d0000 {
>> + compatible = "hisilicon,gpio-ascend910";
>> + reg = <0x840d0000 0x1000>;
>> + ngpios = <0x20>;
> Convention for counting is to use decimal numbers.
>
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupts = <0x0 33 0x4>;
> This looks like standard IRQ flags, so use respective defines.
Sorry, I don't get this, you mean like this? :
interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
Thanks.
>
> Best regards,
> Krzysztof
>
> .
Powered by blists - more mailing lists