linux-kernel - Re: [PATCH next 2/2] dt-bindings: gpio: add entry for hisilicon,gpio-ascend910

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fbbb805-f215-f079-5e8e-8f5e085da6e9@linaro.org>
Date:   Thu, 27 Oct 2022 08:51:03 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     chenweilong <chenweilong@...wei.com>, f.fangjian@...wei.com,
        linus.walleij@...aro.org, yangyicong@...ilicon.com,
        xuwei5@...wei.com, robh+dt@...nel.org, robh@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH next 2/2] dt-bindings: gpio: add entry for
 hisilicon,gpio-ascend910

On 27/10/2022 03:47, chenweilong wrote:
>> Convention for counting is to use decimal numbers.
>>
>>> +      gpio-controller;
>>> +      #gpio-cells = <2>;
>>> +      interrupts = <0x0 33 0x4>;
>> This looks like standard IRQ flags, so use respective defines.
> 
> Sorry, I don't get this, you mean like this? :
> 
> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;

Yes.

Best regards,
Krzysztof