lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Oct 2022 14:18:03 +0200 From: Borislav Petkov <bp@...en8.de> To: Juergen Gross <jgross@...e.com> Cc: linux-kernel@...r.kernel.org, x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com> Subject: Re: [PATCH v4 11/16] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init On Tue, Oct 04, 2022 at 10:10:18AM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c > index 49b60a427fc9..330aa412be63 100644 > --- a/arch/x86/kernel/cpu/cacheinfo.c > +++ b/arch/x86/kernel/cpu/cacheinfo.c > @@ -1137,3 +1137,10 @@ void cache_cpu_init(void) > cache_enable(); > local_irq_restore(flags); > } > + > +bool cache_aps_delayed_init; Why isn't that static and only the accessors set it or clear it? > +void set_cache_aps_delayed_init(void) > +{ > + cache_aps_delayed_init = true; > +} Otherwise, there's no point for this thing. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists