linux-kernel - Re: [PATCH v4 11/16] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdf0b33f-b332-1597-3922-2ff4fa768929@suse.com>
Date:   Thu, 27 Oct 2022 15:08:54 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v4 11/16] x86/mtrr: let cache_aps_delayed_init replace
 mtrr_aps_delayed_init

On 27.10.22 14:18, Borislav Petkov wrote:
> On Tue, Oct 04, 2022 at 10:10:18AM +0200, Juergen Gross wrote:
>> diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c
>> index 49b60a427fc9..330aa412be63 100644
>> --- a/arch/x86/kernel/cpu/cacheinfo.c
>> +++ b/arch/x86/kernel/cpu/cacheinfo.c
>> @@ -1137,3 +1137,10 @@ void cache_cpu_init(void)
>>   	cache_enable();
>>   	local_irq_restore(flags);
>>   }
>> +
>> +bool cache_aps_delayed_init;
> 
> Why isn't that static and only the accessors set it or clear it?
> 
>> +void set_cache_aps_delayed_init(void)
>> +{
>> +	cache_aps_delayed_init = true;
>> +}
> 
> Otherwise, there's no point for this thing.

Hmm, right.

I'll add a get_cache_aps_delayed_init() accessor.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)