linux-kernel - Re: [PATCH 7/9] fscache,netfs: define flags for prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 14:11:23 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jingbo Xu <jefflexu@...ux.alibaba.com>
Cc:     dhowells@...hat.com, jlayton@...nel.org, linux-cachefs@...hat.com,
        linux-erofs@...ts.ozlabs.org, linux-cifs@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/9] fscache,netfs: define flags for prepare_read()

Jingbo Xu <jefflexu@...ux.alibaba.com> wrote:

> +		if (test_bit(FSCACHE_REQ_COPY_TO_CACHE, &flags))
> +			__set_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags);

Please don't do that in netfslib.  Netfslib shouldn't know about fscache's
inner workings.

David