linux-kernel - Re: [PATCH 9/9] fscache,netfs: move "fscache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 14:13:03 +0100
From:   David Howells <dhowells@...hat.com>
To:     Jingbo Xu <jefflexu@...ux.alibaba.com>
Cc:     dhowells@...hat.com, jlayton@...nel.org, linux-cachefs@...hat.com,
        linux-erofs@...ts.ozlabs.org, linux-cifs@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] fscache,netfs: move "fscache_" prefixed structures to fscache.h

Jingbo Xu <jefflexu@...ux.alibaba.com> wrote:

> diff --git a/include/linux/netfs.h b/include/linux/netfs.h
> index 2ad4e1e88106..1977f953633a 100644
> --- a/include/linux/netfs.h
> +++ b/include/linux/netfs.h
> @@ -16,19 +16,10 @@
>  
>  #include <linux/workqueue.h>
>  #include <linux/fs.h>
> +#include <linux/fscache.h>

Please don't do that.  fscache is based on netfslib, not the other way around.

If anything, I'm tempted to move fscache into netfslib.

David