linux-kernel - Re: [PATCH stable 0/5] Fix missing patches in stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9r9NRATt5YsApkTRBQtXCDGCkCZO9TPtyk9Oi9BUcyw5A@mail.gmail.com>
Date:   Thu, 27 Oct 2022 16:15:52 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
Cc:     linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH stable 0/5] Fix missing patches in stable

On Mon, Oct 17, 2022 at 9:20 PM Saeed Mirzamohammadi
<saeed.mirzamohammadi@...cle.com> wrote:
>
> The following patches has been applied to 6.0 but only patch#2 below
> has been applied to stable. This caused regression with nfs tests in
> all stable releases.
>
> This patchset backports patches 1 and 3-6 to stable.
>
> 1. 868941b14441 fs: remove no_llseek
> 2. 97ef77c52b78 fs: check FMODE_LSEEK to control internal pipe splicing
> 3. 54ef7a47f67d vfio: do not set FMODE_LSEEK flag
> 4. c9eb2d427c1c dma-buf: remove useless FMODE_LSEEK flag
> 5. 4e3299eaddff fs: do not compare against ->llseek
> 6. e7478158e137 fs: clear or set FMODE_LSEEK based on llseek function
>
> For 5.10.y and 5.4.y only, a revert of patch#2 is already included.
> Please apply patch#2, for 5.4.y and 5.10.y as well.

This is confusing and there's no way Greg is going to do this right
given the limited information you've provided and wrong ordering of
the patches. I couldn't really even follow this without some detective
work, and I wrote these patches.

Here are your options:
- Let the revert of "97ef77c52b78 fs: check FMODE_LSEEK to control
internal pipe splicing" work its way into all stable trees; or
- Send a proper backport series for each and every stable kernel,
depending on what each one needs. Send these as different patchsets,
marked with the version number it applies to. Make sure they apply,
compile, and work correctly.

Anything short of those is going to lead to chaos.

Jason