linux-kernel - Re: [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 14:44:01 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Asutosh Das <quic_asutoshd@...cinc.com>
Cc:     quic_cang@...cinc.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, quic_nguyenb@...cinc.com,
        quic_xiaosenh@...cinc.com, stanley.chu@...iatek.com,
        eddie.huang@...iatek.com, daejun7.park@...sung.com,
        avri.altman@....com, mani@...nel.org, beanhuo@...ron.com,
        quic_richardp@...cinc.com, linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue
 capability

On 10/28/22 09:51, Asutosh Das wrote:
> On Thu, Oct 27 2022 at 14:10 -0700, Bart Van Assche wrote:
>> Since UFSHCI 4.0 controllers must support UFSHCI 3.0, shouldn't users 
>> have a way to disable MCQ, e.g. via a kernel module parameter?
>>
> I can add a kernel module parameter to disable MCQ.
> I think adding it to host driver (e.g. ufs-qcom) would be good.
> Please let me know if you have a better place in mind.

Since this functionality is useful for all host controllers please add 
it in the core UFS host controller driver (drivers/ufs/core/ufshcd.c).

Thanks,

Bart.