linux-kernel - RE: [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 30 Oct 2022 12:11:33 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Bart Van Assche <bvanassche@....org>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
        "quic_xiaosenh@...cinc.com" <quic_xiaosenh@...cinc.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "eddie.huang@...iatek.com" <eddie.huang@...iatek.com>,
        "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        "mani@...nel.org" <mani@...nel.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "quic_richardp@...cinc.com" <quic_richardp@...cinc.com>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue
 capability

> 
> On 10/20/22 11:03, Asutosh Das wrote:
> > +
> > +     /*
> > +      * This capability allows the host controller driver to turn on/off
> > +      * MCQ mode. MCQ mode may be used to increase performance.
> > +      */
> > +     UFSHCD_CAP_MCQ_EN                               = 1 << 12,
Needs rebase?
UFSHCD_CAP_WB_WITH_CLK_SCALING already occupies that bit.

Thanks,
Avri

> >   };
> 
> I prefer that the above flag would only be introduced after a need
> appears to disable MCQ, e.g. discovery of a host controller that is too
> broken to enable MCQ.
> 
> Since UFSHCI 4.0 controllers must support UFSHCI 3.0, shouldn't users
> have a way to disable MCQ, e.g. via a kernel module parameter?
> 
> Thanks,
> 
> Bart.