linux-kernel - Re: [PATCH] spi: spi-mem: Fix typo (of -> or)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f5235b8-9f35-6f7c-37b4-8094e476fbd4@ti.com>
Date:   Fri, 28 Oct 2022 12:00:23 +0530
From:   "Gole, Dhruva" <d-gole@...com>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        <linux-spi@...r.kernel.org>
CC:     Mark Brown <broonie@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-mem: Fix typo (of -> or)

Hi Jonathan,

On 10/8/2022 8:44 PM, Jonathan Neuschäfer wrote:
> In this instance, "or" makes more sense than "of", so I guess that "or"
> was intended and "of" was a typo.

Using "I guess" is generally discouraged in commit messages. Please read 
up the documentation

on submitting patches:

 > Describe your changes in imperative mood, e.g. “make xyzzy do frotz” 
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to 
do frotz”, as if you are giving orders to the codebase to change its 
behaviour.

link: 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
>   include/linux/spi/spi-mem.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h
> index 2ba044d0d5e5b..8e984d75f5b6c 100644
> --- a/include/linux/spi/spi-mem.h
> +++ b/include/linux/spi/spi-mem.h
> @@ -225,7 +225,7 @@ static inline void *spi_mem_get_drvdata(struct spi_mem *mem)
>   /**
>    * struct spi_controller_mem_ops - SPI memory operations
>    * @adjust_op_size: shrink the data xfer of an operation to match controller's
> - *		    limitations (can be alignment of max RX/TX size
> + *		    limitations (can be alignment or max RX/TX size
>    *		    limitations)
>    * @supports_op: check if an operation is supported by the controller
>    * @exec_op: execute a SPI memory operation
> --
> 2.35.1
>
-- 
Regards,
Dhruva Gole <d-gole@...com>