linux-kernel - Re: [PATCH] spi: spi-mem: Fix typo (of -> or)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1unCzyjQ1ZzgU/S@probook>
Date:   Fri, 28 Oct 2022 11:55:23 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     "Gole, Dhruva" <d-gole@...com>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-spi@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-mem: Fix typo (of -> or)

On Fri, Oct 28, 2022 at 12:00:23PM +0530, Gole, Dhruva wrote:
> Hi Jonathan,
> 
> On 10/8/2022 8:44 PM, Jonathan Neuschäfer wrote:
> > In this instance, "or" makes more sense than "of", so I guess that "or"
> > was intended and "of" was a typo.
> 
> Using "I guess" is generally discouraged in commit messages. Please read up
> the documentation

It is truthful though: I did not write the original comment, and my
change is based on my interpretation of the comment.

> on submitting patches:
> 
> > Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
> instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do
> frotz”, as if you are giving orders to the codebase to change its behaviour.

The imperative-mood description is already in the commit title
(or subject line). I am not making a functional change to the code, so
"fix a typo" is really all that is to be said in imperative mood, the
rest is an explanation of why I think this makes sense.

> 
> link: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes


Best regards,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)