linux-kernel - Re: [PATCH v2] HID: uclogic: Add support for XP-PEN Deco LW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21CA0A00-1B9F-4E97-B942-A3B7CAA2B52E@redpilled.dev>
Date:   Sat, 29 Oct 2022 15:13:19 +0300
From:   Mia Kanashi <chad@...pilled.dev>
To:     José Expósito <jose.exposito89@...il.com>
CC:     jikos@...nel.org, benjamin.tissoires@...hat.com, spbnick@...il.com,
        pobrn@...tonmail.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Andreas Grosse <andig.mail@...nline.de>
Subject: Re: [PATCH v2] HID: uclogic: Add support for XP-PEN Deco LW

On 29 October 2022 10:58:32 EEST, "José Expósito" <jose.exposito89@...il.com> wrote:
>Hi Mia,
>
>Thanks for testing :D
>
>On Sat, Oct 29, 2022 at 03:28:10AM +0300, Mia Kanashi wrote:
>> Hello!
>> 
>> Before device sends a battery report, you can notice garbage values in a power supply capacity.
>> 
>> You can see this by running
>> `watch -n0.1 cat /sys/class/power_supply/hid-28bd-935-battery/uevent`
>> and then connecting the tablet.
>> 
>> You can set it to a value here, but i think this is a problem in the global hid driver?
>
>That shouldn't be problematic, because the charging status should be
>initially set to unknown and change to charging/discharging [1] once
>the device sends the first report.
>
>Your desktop environment shouldn't display the battery percentage
>while the status is unknown, so the initial values are ignored.
>
>Here is my output of my XP-Pen Deco SW before receiving the battery
>percentage:
>
> POWER_SUPPLY_NAME=hid-28bd-933-battery
> POWER_SUPPLY_TYPE=Battery
> POWER_SUPPLY_PRESENT=1
> POWER_SUPPLY_ONLINE=1
> POWER_SUPPLY_MODEL_NAME=UGTABLET Deco Pro SW
> POWER_SUPPLY_SCOPE=Device
>
>And after:
>
> POWER_SUPPLY_NAME=hid-28bd-933-battery
> POWER_SUPPLY_TYPE=Battery
> POWER_SUPPLY_PRESENT=1
> POWER_SUPPLY_ONLINE=1
> POWER_SUPPLY_CAPACITY=99
> POWER_SUPPLY_MODEL_NAME=UGTABLET Deco Pro SW
> POWER_SUPPLY_STATUS=Discharging
> POWER_SUPPLY_SCOPE=Device
>
>Jose
>
>[1] Actually it should be set to discharging until this gets merged:
>    https://lore.kernel.org/linux-input/20221028181849.23157-1-jose.exposito89@gmail.com/T/

Hello, for me it first looks like this:

 POWER_SUPPLY_NAME=hid-28bd-935-battery
 POWER_SUPPLY_TYPE=Battery
 POWER_SUPPLY_PRESENT=1
 POWER_SUPPLY_ONLINE=1
 POWER_SUPPLY_MODEL_NAME=Hanvon Ugee Deco LW
 POWER_SUPPLY_SCOPE=Device

Then it looks like this for a very brief (or not so brief) period of time, it also isn't always there, i suggest trying plugging it in multiple times:

 POWER_SUPPLY_NAME=hid-28bd-935-battery
 POWER_SUPPLY_TYPE=Battery
 POWER_SUPPLY_PRESENT=1
 POWER_SUPPLY_ONLINE=1
 POWER_SUPPLY_CAPACITY=160
 POWER_SUPPLY_MODEL_NAME=Hanvon Ugee Deco LW
 POWER_SUPPLY_STATUS=Discharging
 POWER_SUPPLY_SCOPE=Device

Here value is 160, obvious garbage, it can have any other value depending on your luck.

And then after that it looks like this:

 POWER_SUPPLY_NAME=hid-28bd-935-battery
 POWER_SUPPLY_TYPE=Battery
 POWER_SUPPLY_PRESENT=1
 POWER_SUPPLY_ONLINE=1
 POWER_SUPPLY_CAPACITY=40
 POWER_SUPPLY_MODEL_NAME=Hanvon Ugee Deco LW
 POWER_SUPPLY_STATUS=Discharging
 POWER_SUPPLY_SCOPE=Device


>[1] Actually it should be set to discharging until this gets merged:
>    https://lore.kernel.org/linux-input/20221028181849.23157-1-jose.exposito89@gmail.com/T/

But i also currently applied this ^ patch, i will try testing without it and then report.