linux-kernel - Re: [RESEND PATCH v5 4/4] drivers: misc: Add Support for TMR Inject IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202210301513.rnkRcCIU-lkp@intel.com>
Date:   Sun, 30 Oct 2022 15:25:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Appana Durga Kedareswara rao 
        <appana.durga.kedareswara.rao@....com>, appanad@....com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        appana.durga.rao@...inx.com, michal.simek@...inx.com,
        derek.kiernan@...inx.com, dragan.cvetic@...inx.com, arnd@...db.de,
        gregkh@...uxfoundation.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, git@....com
Subject: Re: [RESEND PATCH v5 4/4] drivers: misc: Add Support for TMR Inject
 IP

Hi Appana,

I love your patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next soc/for-next linus/master v6.1-rc2 next-20221028]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Appana-Durga-Kedareswara-rao/drivers-misc-Add-support-for-TMR-Manager-and-Inject-IPs/20221028-170329
patch link:    https://lore.kernel.org/r/20221028090106.1456940-5-appana.durga.kedareswara.rao%40amd.com
patch subject: [RESEND PATCH v5 4/4] drivers: misc: Add Support for TMR Inject IP
config: microblaze-allmodconfig
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7dd0b83d500b83048e87c2c13d875c656a70386f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Appana-Durga-Kedareswara-rao/drivers-misc-Add-support-for-TMR-Manager-and-Inject-IPs/20221028-170329
        git checkout 7dd0b83d500b83048e87c2c13d875c656a70386f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/misc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/xilinx_tmr_inject.c:70:6: warning: no previous prototype for 'xtmr_init_debugfs' [-Wmissing-prototypes]
      70 | void xtmr_init_debugfs(struct xtmr_inject_dev *xtmr_inject)
         |      ^~~~~~~~~~~~~~~~~


vim +/xtmr_init_debugfs +70 drivers/misc/xilinx_tmr_inject.c

    69	
  > 70	void xtmr_init_debugfs(struct xtmr_inject_dev *xtmr_inject)
    71	{
    72		struct dentry *dir;
    73	
    74		dbgfs_root = debugfs_create_dir("xtmr_inject", NULL);
    75		dir = fault_create_debugfs_attr("inject_fault", dbgfs_root,
    76						&inject_fault);
    77		debugfs_create_file("inject_fault", 0200, dir, NULL,
    78				    &xtmr_inject_fops);
    79	}
    80	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (308043 bytes)