linux-kernel - Re: [PATCH] power: supply: core: repair kernel-doc for power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 23:50:13 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-pm@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: core: repair kernel-doc for
 power_supply_vbat2ri()

Hi,

On Mon, Oct 31, 2022 at 04:18:08PM +0100, Lukas Bulwahn wrote:
> The function power_supply_vbat2ri() does not have a parameter called table,
> despite it being mentioned in the kernel-doc comment. The table is actually
> obtained from the info parameter, the battery information container. Hence,
> ./scripts/kernel-doc -none drivers/power/supply/power_supply_core.c warns
> about this excess function parameter.
> 
> Adjust the kernel-doc comment for power_supply_vbat2ri() for make W=1
> happiness.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/power_supply_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 4b5fb172fa99..9035e349bf53 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -870,7 +870,6 @@ EXPORT_SYMBOL_GPL(power_supply_temp2resist_simple);
>   * power_supply_vbat2ri() - find the battery internal resistance
>   * from the battery voltage
>   * @info: The battery information container
> - * @table: Pointer to battery resistance temperature table
>   * @vbat_uv: The battery voltage in microvolt
>   * @charging: If we are charging (true) or not (false)
>   *
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)