linux-kernel - RE: [PATCH 1/3] ASoC: adau1372: fix mclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 11:20:41 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Maarten Zanders <maarten.zanders@...d.be>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3] ASoC: adau1372: fix mclk



> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@...d.be>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@...afoo.de>; Sa, Nuno
> <Nuno.Sa@...log.com>; Liam Girdwood <lgirdwood@...il.com>; Mark
> Brown <broonie@...nel.org>; Jaroslav Kysela <perex@...ex.cz>; Takashi
> Iwai <tiwai@...e.com>
> Cc: Maarten Zanders <maarten.zanders@...d.be>; alsa-devel@...a-
> project.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 1/3] ASoC: adau1372: fix mclk
> 
> [External]
> 
> "mclk" is retrieved from the configuration and assigned to adau1372->clk.
> However adau1372->mclk (==NULL) is used for clk_prepare_enable() and
> clk_disable_unprepare() which don't have any effect.
> 
> Remove .clk from struct adau1372 and use .mclk throughout.
> This change ensures that the input clock is switched on/off when the
> bias level is changed.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders@...d.be>
> ---

I guess this needs a Fixes: tag?

- Nuno Sá