lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ0PR03MB6778F2F397C62329B3B4D67E99379@SJ0PR03MB6778.namprd03.prod.outlook.com>
Date:   Mon, 31 Oct 2022 11:22:44 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Maarten Zanders <maarten.zanders@...d.be>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
CC:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit



> -----Original Message-----
> From: Maarten Zanders <maarten.zanders@...d.be>
> Sent: Friday, October 28, 2022 5:26 PM
> To: Lars-Peter Clausen <lars@...afoo.de>; Sa, Nuno
> <Nuno.Sa@...log.com>; Liam Girdwood <lgirdwood@...il.com>; Mark
> Brown <broonie@...nel.org>; Jaroslav Kysela <perex@...ex.cz>; Takashi
> Iwai <tiwai@...e.com>
> Cc: Maarten Zanders <maarten.zanders@...d.be>; alsa-devel@...a-
> project.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
> 
> [External]
> 
> The DAPM control for PGAx uses the PGA mute bit for
> power management. This bit is active high but is set to
> non-inverted (ie when powering, it will mute).
> The ALSA control "PGA x Capture Switch" uses the active
> high PGA_ENx bit, but is set to inverted. So when
> enabling this switch, the PGA gets disabled.
> 
> To correct the behaviour, invert both these bits.
> 
> Signed-off-by: Maarten Zanders <maarten.zanders@...d.be>
> ---

Also looks like a fix so a Fixes: tag? If so, the patch should come
before ("ASoC: adau1372: add support for S24_LE mode")

- Nuno Sá

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ