linux-kernel - [PATCH] x86/cpu: fix undefined behavior in bit shift for intel_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221031114340.4185587-1-cuigaosheng1@huawei.com>
Date:   Mon, 31 Oct 2022 19:43:40 +0800
From:   Gaosheng Cui <cuigaosheng1@...wei.com>
To:     <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <tony.luck@...el.com>, <pawan.kumar.gupta@...ux.intel.com>,
        <pbonzini@...hat.com>, <chenyi.qiang@...el.com>,
        <jithu.joseph@...el.com>, <alexs@...nel.org>,
        <cuigaosheng1@...wei.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86/cpu: fix undefined behavior in bit shift for intel_detect_tlb

Shifting signed 32-bit value by 31 bits is undefined, so changing
significant bit to unsigned. The UBSAN warning calltrace like below:

UBSAN: shift-out-of-bounds in arch/x86/kernel/cpu/intel.c:948:21
left shift of 1 by 31 places cannot be represented in type 'int'
Call Trace:
 <TASK>
 dump_stack_lvl+0x7d/0xa5
 dump_stack+0x15/0x1b
 ubsan_epilogue+0xe/0x4e
 __ubsan_handle_shift_out_of_bounds+0x1e7/0x20c
 intel_detect_tlb+0x114/0xbd0
 identify_boot_cpu+0x29/0x9e
 check_bugs+0x2f/0x15a5
 start_kernel+0xc3f/0xc78
 x86_64_start_reservations+0x24/0x2a
 x86_64_start_kernel+0xed/0xf8
 secondary_startup_64_no_verify+0xe5/0xeb
 </TASK>

Fixes: e0ba94f14f74 ("x86/tlb_info: get last level TLB entry number of CPU")
Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
---
 arch/x86/kernel/cpu/intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 2d7ea5480ec3..121c1c38162a 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -945,7 +945,7 @@ static void intel_detect_tlb(struct cpuinfo_x86 *c)
 
 		/* If bit 31 is set, this is an unknown format */
 		for (j = 0 ; j < 3 ; j++)
-			if (regs[j] & (1 << 31))
+			if (regs[j] & (1U << 31))
 				regs[j] = 0;
 
 		/* Byte 0 is level count, not a descriptor */
-- 
2.25.1