lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Nov 2022 12:18:58 -0600 From: Jens Axboe <axboe@...nel.dk> To: Christoph Hellwig <hch@....de>, Jinlong Chen <nickyc975@....edu.cn> Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] blk-mq: improve error handling in blk_mq_alloc_rq_map() On 11/1/22 11:34 AM, Christoph Hellwig wrote: >> if (!tags) >> - return NULL; >> + goto err_out; > > Using a label just for the direct error return here is a bit silly. Plus that's not idiomatic code for cleanup, just keep the NULL return if there's no cleanup to be done. -- Jens Axboe
Powered by blists - more mailing lists