linux-kernel - Re: [PATCH 4/4] blk-mq: improve readability of blk_mq_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <074cfae7-982d-5273-e63e-8db4fa22db14@nvidia.com>
Date:   Wed, 2 Nov 2022 01:16:08 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Jinlong Chen <nickyc975@....edu.cn>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] blk-mq: improve readability of blk_mq_alloc_request()


>> +static struct request *blk_mq_alloc_request_nocache(struct request_queue *q,
>> +		blk_opf_t opf, blk_mq_req_flags_t flags)
> 
> The name is a bit odd, but I can't think off a better one.
> 
>> +	struct blk_mq_alloc_data data = {
>>   			.q		= q,
>>   			.flags		= flags,
>>   			.cmd_flags	= opf,
>>   			.nr_tags	= 1,
>>   		};
> 
> And this now has superflous indenation.  Overall, while the separate
> helper looks marginally nicer, I'm not really sure it is worth the
> churn.

existing code is fine here than adding this indentation which
is not worth a churn...

-ck