linux-kernel - Re: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 1 Nov 2022 16:45:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
        ndesaulniers@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, peterz@...radead.org,
        llvm@...ts.linux.dev, ashutosh.dixit@...el.com,
        andi.shyti@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bitfield: Use argument type for size comparison on
 Bitfield access macros

Hi Gwan-gyeong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
patch link:    https://lore.kernel.org/r/20221029053429.38381-1-gwan-gyeong.mun%40intel.com
patch subject: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros
config: arm-randconfig-s053-20221101
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/91f22fce5cc0639c001bcf755c9dec0913073876
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
        git checkout 91f22fce5cc0639c001bcf755c9dec0913073876
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/infiniband/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
   drivers/infiniband/core/cm.c:1272:20: sparse: sparse: cast from restricted __be32
>> drivers/infiniband/core/cm.c:1613:18: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:1638:34: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:1655:34: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:1658:34: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:1687:17: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:1715:25: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2030:21: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2037:21: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2044:21: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2051:21: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2088:28: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2172:25: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2981:25: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:2993:13: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:3032:21: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:3237:40: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:3239:40: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)
   drivers/infiniband/core/cm.c:3530:23: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1)

vim +1613 drivers/infiniband/core/cm.c

a977049dacdef6a Hal Rosenstock              2005-07-27  1610  
6b3c0e6e6d5abfe Dasaratharaman Chandramouli 2017-06-08  1611  static bool cm_req_has_alt_path(struct cm_req_msg *req_msg)
6b3c0e6e6d5abfe Dasaratharaman Chandramouli 2017-06-08  1612  {
91b60a7128d9624 Jason Gunthorpe             2020-01-16 @1613  	return ((cpu_to_be16(
91b60a7128d9624 Jason Gunthorpe             2020-01-16  1614  			IBA_GET(CM_REQ_ALTERNATE_LOCAL_PORT_LID, req_msg))) ||
4ca662a30a3c9c8 Jason Gunthorpe             2020-01-16  1615  		(ib_is_opa_gid(IBA_GET_MEM_PTR(CM_REQ_ALTERNATE_LOCAL_PORT_GID,
4ca662a30a3c9c8 Jason Gunthorpe             2020-01-16  1616  					       req_msg))));
6b3c0e6e6d5abfe Dasaratharaman Chandramouli 2017-06-08  1617  }
6b3c0e6e6d5abfe Dasaratharaman Chandramouli 2017-06-08  1618  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (120518 bytes)