linux-kernel - Re: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 17:05:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
        ndesaulniers@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, peterz@...radead.org,
        llvm@...ts.linux.dev, ashutosh.dixit@...el.com,
        andi.shyti@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bitfield: Use argument type for size comparison on
 Bitfield access macros

Hi Gwan-gyeong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
patch link:    https://lore.kernel.org/r/20221029053429.38381-1-gwan-gyeong.mun%40intel.com
patch subject: [PATCH] bitfield: Use argument type for size comparison on Bitfield access macros
config: ia64-randconfig-s041-20221031
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/91f22fce5cc0639c001bcf755c9dec0913073876
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gwan-gyeong-Mun/bitfield-Use-argument-type-for-size-comparison-on-Bitfield-access-macros/20221029-133640
        git checkout 91f22fce5cc0639c001bcf755c9dec0913073876
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/i2c/busses/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
   drivers/i2c/busses/i2c-npcm7xx.c:1135:61: sparse: sparse: Using plain integer as NULL pointer
>> drivers/i2c/busses/i2c-npcm7xx.c:466:18: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:479:18: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:1655:13: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:1660:13: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:1666:13: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:1681:13: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)
   drivers/i2c/busses/i2c-npcm7xx.c:1687:13: sparse: sparse: cast truncates bits from constant value (ffffff01 becomes 1)

vim +466 drivers/i2c/busses/i2c-npcm7xx.c

56a1485b102ed1 Tali Perry  2020-05-27  455  
56a1485b102ed1 Tali Perry  2020-05-27  456  static inline bool npcm_i2c_tx_fifo_empty(struct npcm_i2c *bus)
56a1485b102ed1 Tali Perry  2020-05-27  457  {
56a1485b102ed1 Tali Perry  2020-05-27  458  	u8 tx_fifo_sts;
56a1485b102ed1 Tali Perry  2020-05-27  459  
56a1485b102ed1 Tali Perry  2020-05-27  460  	tx_fifo_sts = ioread8(bus->reg + NPCM_I2CTXF_STS);
56a1485b102ed1 Tali Perry  2020-05-27  461  	/* check if TX FIFO is not empty */
bbc38ed53a02a7 Tyrone Ting 2022-05-25  462  	if ((tx_fifo_sts & bus->data->txf_sts_tx_bytes) == 0)
56a1485b102ed1 Tali Perry  2020-05-27  463  		return false;
56a1485b102ed1 Tali Perry  2020-05-27  464  
56a1485b102ed1 Tali Perry  2020-05-27  465  	/* check if TX FIFO status bit is set: */
56a1485b102ed1 Tali Perry  2020-05-27 @466  	return !!FIELD_GET(NPCM_I2CTXF_STS_TX_THST, tx_fifo_sts);
56a1485b102ed1 Tali Perry  2020-05-27  467  }
56a1485b102ed1 Tali Perry  2020-05-27  468  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (117774 bytes)