linux-kernel - Re: [RESEND PATCH v2] staging: most: dim2: hal: aligning function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMk1CBNsheLvpw=jvZrbyK3MC1VJjoBNeuoCQsmCutBTat3jmw@mail.gmail.com>
Date:   Tue, 1 Nov 2022 13:34:48 +0300
From:   jovial umwari <umwarijovial@...il.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [RESEND PATCH v2] staging: most: dim2: hal: aligning function parameters

Will do. Thanks

On Tue, 1 Nov 2022 at 11:39, Julia Lawall <julia.lawall@...ia.fr> wrote:
>
>
>
> On Tue, 1 Nov 2022, UMWARI JOVIAL wrote:
>
> > According to Linux Kernel Coding Style, lines should not end with a '('
> > Fix-issue reported by checkpatch.pl script.
>
> How about something like "To improve readability, start the list of
> function parameters on the same line as the function name.  Issue reported
> by checkpatch."
>
> That would more clearly explain the intent behind the change.
>
> julia
>
>
> >
> > Signed-off-by: UMWARI JOVIAL <umwarijovial@...il.com>
> > ---
> >
> > Changes in v2:
> >     1.Resending this patch because it was sent multiple times earlier.No
> >       functional changes.
> >
> >  drivers/staging/most/dim2/hal.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> > index a5d40b5b138a..6abe3ab2b2cf 100644
> > --- a/drivers/staging/most/dim2/hal.c
> > +++ b/drivers/staging/most/dim2/hal.c
> > @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
> >               dim2_clear_ctr(ctr_addr);
> >  }
> >
> > -static void dim2_configure_channel(
> > -     u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> > -     u16 packet_length)
> > +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> > +                                u16 hw_buffer_size, u16 packet_length)
> >  {
> >       dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
> >       dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> > --
> > 2.25.1
> >
> >
> >