linux-kernel - Re: [PATCH v2 2/2] iio: adc: add ADC driver for the TI LMP92064 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 18:36:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Leonard Göhrs <l.goehrs@...gutronix.de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>, kernel@...gutronix.de
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add ADC driver for the TI LMP92064
 controller

Hi Leonard,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.1-rc3 next-20221101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leonard-G-hrs/dt-bindings-iio-adc-add-TI-LMP92064-controller/20221101-145036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20221101064804.720050-2-l.goehrs%40pengutronix.de
patch subject: [PATCH v2 2/2] iio: adc: add ADC driver for the TI LMP92064 controller
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/4b264b5bc9425f051a3ce5c5a9a30a66d3a0a477
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Leonard-G-hrs/dt-bindings-iio-adc-add-TI-LMP92064-controller/20221101-145036
        git checkout 4b264b5bc9425f051a3ce5c5a9a30a66d3a0a477
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/iio/adc/ti-lmp92064.c: In function 'lmp92064_adc_probe':
   drivers/iio/adc/ti-lmp92064.c:267:15: error: implicit declaration of function 'devm_regulator_get_enable'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration]
     267 |         ret = devm_regulator_get_enable(dev, "vdd");
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
         |               devm_regulator_get_optional
   At top level:
>> drivers/iio/adc/ti-lmp92064.c:293:35: warning: 'lmp92064_id_table' defined but not used [-Wunused-const-variable=]
     293 | static const struct spi_device_id lmp92064_id_table[] = {
         |                                   ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/lmp92064_id_table +293 drivers/iio/adc/ti-lmp92064.c

   292	
 > 293	static const struct spi_device_id lmp92064_id_table[] = {
   294		{ "lmp92064", 0 },
   295		{}
   296	};
   297	MODULE_DEVICE_TABLE(spi, lmp92064_id_table);
   298	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (289502 bytes)