[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bfc8e714fbe80a16428a447768def5764083526d.camel@perches.com>
Date: Wed, 02 Nov 2022 09:42:44 -0700
From: Joe Perches <joe@...ches.com>
To: Tanjuate Brunostar <tanjubrunostar0@...il.com>,
gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
outreachy@...ts.linux.dev
Subject: Re: [PATCH V4 1/2] staging: vt6655: change the function name
s_vFillRTSHead
On Wed, 2022-11-02 at 14:08 +0000, Tanjuate Brunostar wrote:
> Remove the use of Hungarian notation, which is not used in the Linux
> kernel. Reported by checkpatch
[]
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
[]
> @@ -23,7 +23,7 @@
> * s_uGetTxRsvTime- get frame reserved time
> * s_vFillCTSHead- fulfill CTS ctl header
> * s_vFillFragParameter- Set fragment ctl parameter.
> - * s_vFillRTSHead- fulfill RTS ctl header
> + * fill_rts_header- fulfill RTS ctl header
> * s_vFillTxKey- fulfill tx encrypt key
> * s_vSWencryption- Software encrypt header
> * vDMA0_tx_80211- tx 802.11 frame via dma0
> @@ -85,15 +85,15 @@ static const unsigned short fb_opt1[2][5] = {
> #define DATADUR_A_F1 13
>
> /*--------------------- Static Functions --------------------------*/
> -static void s_vFillRTSHead(struct vnt_private *pDevice,
> - unsigned char byPktType,
> - void *pvRTS,
> - unsigned int cbFrameLength,
> - bool bNeedAck,
> - bool bDisCRC,
> - struct ieee80211_hdr *hdr,
> - unsigned short wCurrentRate,
> - unsigned char byFBOption);
> +static void fill_rts_head(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + void *pvRTS,
> + unsigned int cbFrameLength,
> + bool bNeedAck,
> + bool bDisCRC,
> + struct ieee80211_hdr *hdr,
> + unsigned short wCurrentRate,
> + unsigned char byFBOption);
Please compile the files modified by your patches _before_ submitting them.
Note the mismatch in your naming for this function prototype and the
actual function.
fill_rts_head vs fill_rts_header.
I believe this was already pointed out to you by the kernel robot.
Powered by blists - more mailing lists