linux-kernel - RE: [PATCH v2 2/4] pwm: Add Apple PWM controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB592280D795F3F6E1B4BBAA9786399@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Wed, 2 Nov 2022 16:43:28 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Sasha Finkelstein <fnkl.kernel@...il.com>
CC:     "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "marcan@...can.st" <marcan@...can.st>,
        "sven@...npeter.dev" <sven@...npeter.dev>,
        "alyssa@...enzweig.io" <alyssa@...enzweig.io>,
        "asahi@...ts.linux.dev" <asahi@...ts.linux.dev>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/4] pwm: Add Apple PWM controller

> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller
> 
> On Wed, 2 Nov 2022 at 19:29, Biju Das <biju.das.jz@...renesas.com>
> wrote:
> >
> > Then enable the clk whenever pwm is enabled And disable the clk
> > whenever pwm is disabled.
> I can do that, but I do not see the point in doing that. This clock is
> active whenever the system is turned on, all this will result in is
> some unnecessary clock refcount increments/decrements.

OK for me, as I do not know about your system. I just pointed out 
you are unnecessarily turning on the clock during probe
even if the pwm is not used.

Cheers,
Biju