linux-kernel - Re: [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2022 08:19:00 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Tanjuate Brunostar <tanjubrunostar0@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the
 file rxtx.c

On Tue, Nov 01, 2022 at 11:15:37PM +0100, Philipp Hortmann wrote:
> On 11/1/22 19:17, Tanjuate Brunostar wrote:
> > These fixes are focused on the function s_vFillRTSHead
> > 
> > v3: changed the function name from fill_rts_head to fill_rts_header as
> > head is conventionally used in lists
> > 
> > v2: changed confusing changelog messages
> > 
> > Tanjuate Brunostar (2):
> >    staging: vt6655: change the function name s_vFillRTSHead
> >    staging: vt6655: Join some lines of code to avoid code lines ending in
> >      (
> > 
> >   drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++-------------------
> >   1 file changed, 22 insertions(+), 26 deletions(-)
> > 
> 
> Patch failed at 0001 staging: vt6655: change the function name
> s_vFillRTSHead
> 
> 
> WARNING: line length of 138 exceeds 100 columns
> #58: FILE: drivers/staging/vt6655/rxtx.c:915:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> WARNING: line length of 138 exceeds 100 columns
> #67: FILE: drivers/staging/vt6655/rxtx.c:934:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> WARNING: line length of 138 exceeds 100 columns
> #76: FILE: drivers/staging/vt6655/rxtx.c:948:
> +			fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK,
> bDisCRC, psEthHeader, wCurrentRate, byFBOption);
> 
> May be you need to consider to break this lines.

Not in this commit, just stick to doing one thing per patch.  This line
is already "too long" so it is not a new problem being introduced with
this change.  It is fine as-is.

thanks,

greg k-h