linux-kernel - Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2IZaxukERXNcPGR@hovoldconsulting.com>
Date:   Wed, 2 Nov 2022 08:16:59 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Shazad Hussain <quic_shazhuss@...cinc.com>, andersson@...nel.org,
        bmasney@...hat.com, Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for
 gcc_ufs_ref_clkref_clk

On Tue, Nov 01, 2022 at 11:23:59AM -0700, Stephen Boyd wrote:
> Quoting Shazad Hussain (2022-10-30 07:23:33)
> > Since 'commit f3aa975e230e ("arm64: dts: qcom: sc8280xp: correct ref
> 
> So we should have a Fixes tag for this commit? Or really back to the
> beginning of the driver?
> 
> > clock for ufs_mem_phy")' we need to explicitly make cxo as parent to
> > gcc_ufs_ref_clkref_clk to have an independent vote from ufs_mem_phy.

The commit message is slightly misleading as this affects the other UFS
PHY as well.

If CX is indeed a parent of this clock then the issue has been there
since the clock driver was added. (And otherwise, the PHY binding may
need to be amended instead.)

Johan