linux-kernel - Re: [PATCH linux-next] ionic: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17ef4641-7cb3-fea8-4b1a-30b90c1719a1@amd.com>
Date:   Wed, 2 Nov 2022 09:07:34 -0700
From:   Shannon Nelson <shnelson@....com>
To:     zhang.songyi@....com.cn, snelson@...sando.io
Cc:     drivers@...sando.io, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, brett@...sando.io,
        mohamed@...sando.io, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jiang.xuexin@....com.cn,
        xue.zhihong@....com.cn
Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable

On 11/2/22 6:48 AM, zhang.songyi@....com.cn wrote:
>  From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001
> From: zhang songyi <zhang.songyi@....com.cn>
> Date: Wed, 2 Nov 2022 20:57:40 +0800
> Subject: [PATCH linux-next] ionic: remove redundant ret variable
> 
> Return value from ionic_set_features() directly instead of taking this in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>

Acked-by: Shannon Nelson <snelson@...sando.io>

... although these changes usually go through the net or net-next trees.
sln



> ---
>   drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 4dd16c487f2b..a68d748502fd 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1557,14 +1557,11 @@ static int ionic_set_features(struct net_device *netdev,
>                    netdev_features_t features)
>   {
>      struct ionic_lif *lif = netdev_priv(netdev);
> -   int err;
> 
>      netdev_dbg(netdev, "%s: lif->features=0x%08llx new_features=0x%08llx\n",
>             __func__, (u64)lif->netdev->features, (u64)features);
> 
> -   err = ionic_set_nic_features(lif, features);
> -
> -   return err;
> +   return ionic_set_nic_features(lif, features);
>   }
> 
>   static int ionic_set_attr_mac(struct ionic_lif *lif, u8 *mac)
> --
> 2.15.2