linux-kernel - Re: [PATCH linux-next] ionic: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 20:50:32 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     zhang.songyi@....com.cn
Cc:     Shannon Nelson <shnelson@....com>, snelson@...sando.io,
        drivers@...sando.io, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, brett@...sando.io, mohamed@...sando.io,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jiang.xuexin@....com.cn, xue.zhihong@....com.cn
Subject: Re: [PATCH linux-next] ionic: remove redundant ret variable

On Wed, 2 Nov 2022 09:07:34 -0700 Shannon Nelson wrote:
> On 11/2/22 6:48 AM, zhang.songyi@....com.cn wrote:
> >  From 06579895d9e3f6441fa30d52e3b585b2015c7e2e Mon Sep 17 00:00:00 2001
> > From: zhang songyi <zhang.songyi@....com.cn>
> > Date: Wed, 2 Nov 2022 20:57:40 +0800
> > Subject: [PATCH linux-next] ionic: remove redundant ret variable
> > 
> > Return value from ionic_set_features() directly instead of taking this in
> > another redundant variable.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: zhang songyi <zhang.songyi@....com.cn>  
> 
> Acked-by: Shannon Nelson <snelson@...sando.io>
> 
> ... although these changes usually go through the net or net-next trees.

net-next in this case, but it doesn't apply, please rebase and repost.