linux-kernel - Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Nov 2022 23:24:37 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Li Huafei <lihuafei1@...wei.com>
Cc:     <mhiramat@...nel.org>, <mark.rutland@....com>,
        <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace_ops

On Wed, 2 Nov 2022 23:23:34 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> I think you misunderstood me. What I was suggesting was to get rid of
> the ftrace_enabled check. The DYNAMIC part is most definitely needed.
> 
> 	if (!command) {
> 		if (ops->flags & FTRACE_OPS_FL_DYNAMIC)
> 			goto out;
> 		return 0;
> 	}


Nevermind, I forgot that the out is before the DYNAMIC check.

   ;-)

-- Steve