linux-kernel - Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e925893e-1099-777e-7485-6dc8f1f37333@huawei.com>
Date:   Thu, 3 Nov 2022 11:38:30 +0800
From:   Li Huafei <lihuafei1@...wei.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     <mhiramat@...nel.org>, <mark.rutland@....com>,
        <linux-kernel@...r.kernel.org>,
        <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ftrace: Fix use-after-free for dynamic ftrace_ops



On 2022/11/3 11:24, Steven Rostedt wrote:
> On Wed, 2 Nov 2022 23:23:34 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>> I think you misunderstood me. What I was suggesting was to get rid of
>> the ftrace_enabled check. The DYNAMIC part is most definitely needed.
>>
>> 	if (!command) {
>> 		if (ops->flags & FTRACE_OPS_FL_DYNAMIC)
>> 			goto out;
>> 		return 0;
>> 	}
> 
> 
> Nevermind, I forgot that the out is before the DYNAMIC check.
> 
>    ;-)
> 

Yes. There we have the DYNAMIC check.

> -- Steve
> 
> .
>