linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 17:36:26 -0500
From:   Andrew Davis <afd@...com>
To:     Nishanth Menon <nm@...com>, Julien Panis <jpanis@...libre.com>
CC:     <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP
 watchdogs as reserved

On 11/3/22 4:47 PM, Nishanth Menon wrote:
> On 19:14-20221103, Julien Panis wrote:
>> MCU wdt is typically used by M4F.
>> Wake up wdt is typically used by DM (R5) firmware.
>>
>> Signed-off-by: Julien Panis <jpanis@...libre.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 93a5f0817efc..9ade591ef563 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -503,6 +503,16 @@ &main_mcan0 {
>>   	status = "disabled";
>>   };
>>   
>> +&mcu_rti0 {
>> +	/* MCU RTI0 is used by M4F firmware */
>> +	status = "reserved";
>> +};
>> +
>> +&wkup_rti0 {
>> +	/* WKUP RTI0 is used by DM firmware */
>> +	status = "reserved";
>> +};
>> +
> 
> If this is the typical usage, should'nt we do this in soc.dtsi than
> sprinkle this through various boards?
> 
> Andrew: ?

These are only "reserved" for certain firmware, you choose your RPROCs
and firmware down at the bottom level in board DTs. So I'd say these
statuses should be set at this same level here.

DM firmware might be the exception as it should always be present,
but for M4F firmware, meh, leave it here.

Andrew

>>   &epwm0 {
>>   	status = "disabled";
>>   };
>> -- 
>> 2.37.3
>>
>