linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221103231002.fqsstlkpgaoa5wm7@tasty>
Date:   Thu, 3 Nov 2022 18:10:02 -0500
From:   Nishanth Menon <nm@...com>
To:     Andrew Davis <afd@...com>
CC:     Julien Panis <jpanis@...libre.com>, <vigneshr@...com>,
        <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP
 watchdogs as reserved

On 17:36-20221103, Andrew Davis wrote:
> On 11/3/22 4:47 PM, Nishanth Menon wrote:
> > On 19:14-20221103, Julien Panis wrote:
> > > MCU wdt is typically used by M4F.
> > > Wake up wdt is typically used by DM (R5) firmware.
> > > 
> > > Signed-off-by: Julien Panis <jpanis@...libre.com>
> > > ---
> > >   arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
> > >   1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > index 93a5f0817efc..9ade591ef563 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> > > @@ -503,6 +503,16 @@ &main_mcan0 {
> > >   	status = "disabled";
> > >   };
> > > +&mcu_rti0 {
> > > +	/* MCU RTI0 is used by M4F firmware */
> > > +	status = "reserved";
> > > +};
> > > +
> > > +&wkup_rti0 {
> > > +	/* WKUP RTI0 is used by DM firmware */
> > > +	status = "reserved";
> > > +};
> > > +
> > 
> > If this is the typical usage, should'nt we do this in soc.dtsi than
> > sprinkle this through various boards?
> > 
> > Andrew: ?
> 
> These are only "reserved" for certain firmware, you choose your RPROCs
> and firmware down at the bottom level in board DTs. So I'd say these
> statuses should be set at this same level here.
> 
> DM firmware might be the exception as it should always be present,
> but for M4F firmware, meh, leave it here.
> 

That makes sense.. Julien: Could you address this please?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D