linux-kernel - Re: [PATCH] Fix tas2562 volume table values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y2PA8Bo59YDKvlRG@sirena.org.uk>
Date:   Thu, 3 Nov 2022 13:24:00 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Juan Alfonso Reyes Ajenjo <jareyes@....com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Martin Povišer" <povik+lin@...ebit.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Fabio Estevam <festevam@...x.de>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gustavo Plaza Roma <gplaza@....com>
Subject: Re: [PATCH] Fix tas2562 volume table values

On Thu, Nov 03, 2022 at 01:03:01PM +0000, Juan Alfonso Reyes Ajenjo wrote:
> This patch fixes -90dB value (0x84a3 instead of 0x695b)
> This patch adds missing -20dB value (0x06666666)
> float_vol_db_lookup must have 56 values as volume is from 0 to 55 (0-110dB)
> 
> Signed-off-by: Juan Alfonso Reyes Ajenjo jareyes@....com<mailto:jareyes@....com>
> Signed-off-by: Gustavo Plaza Roma gplaza@....com<mailto:gplaza@....com>

It looks like this got mangled a bit by your mail client - the signoffs
are rather confused and...

> static const unsigned int float_vol_db_lookup[] = {
> 0x00000d43, 0x000010b2, 0x00001505, 0x00001a67, 0x00002151,
> 0x000029f1, 0x000034cd, 0x00004279, 0x000053af, 0x0000695b,
> -0x0000695b, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> +0x000084a3, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> 0x0001a36e, 0x00021008, 0x000298c0, 0x000344df, 0x00041d8f,

...there's what looks like a lot of whitespace damage which means the
tooling won't be able to understand it.  I usually recommend git
send-email for sending patches, it will avoid most issues.

Also I'd expect Juan's signoff to be last if it's him sending the patch
(possibly Gustavo should be a Co-developed-by or something?).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)