linux-kernel - Re: [PATCH v3] checksyscalls: Ignore fstat to silence build warning on LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <410dcaaf-722c-50ee-9fec-6c80db068eff@loongson.cn>
Date:   Thu, 3 Nov 2022 21:24:44 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Xi Ruoyao <xry111@...111.site>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>, Arnd Bergmann <arnd@...db.de>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v3] checksyscalls: Ignore fstat to silence build warning
 on LoongArch

Hi Andrew,

On 10/12/2022 02:19 PM, Tiezhu Yang wrote:
>
> Cc KERNEL BUILD maintainers:
>
> Masahiro Yamada <masahiroy@...nel.org>
> Michal Marek <michal.lkml@...kovi.net>
> Nick Desaulniers <ndesaulniers@...gle.com>
>
> On 10/09/2022 10:01 PM, Xi Ruoyao wrote:
>> On Sun, 2022-10-09 at 12:33 +0800, Tiezhu Yang wrote:
>>>
>>>
>>> On 08/30/2022 11:27 AM, Tiezhu Yang wrote:
>>>> fstat is replaced by statx on the new architecture, so an exception
>>>> is added to the checksyscalls script to silence the following build
>>>> warning on LoongArch:
>>>>
>>>>   CALL    scripts/checksyscalls.sh
>>>> <stdin>:569:2: warning: #warning syscall fstat not implemented [-
>>>> Wcpp]
>>>
>>> Hi all,
>>>
>>> The above warning still exists when build the latest loongarch-next.
>>>
>>> Do you know which tree this patch will go through?
>>>
>>> Could you please pick it up via your tree in this merge window?
>>
>> A similar change 3ef6ca4f354c ("checksyscalls: Unconditionally ignore
>> fstat{,at}64") was merged through RISC-V tree, so it should be OK to
>> merge this from loongarch-next.
>>
>> Not sure if we need to get an Ack from someone first though.
>>
>
> Since this is a kernel build warning, maybe it is proper through
> linux-kbuild.git.
>
> https://lore.kernel.org/lkml/1661830021-8643-1-git-send-email-yangtiezhu@loongson.cn/
>
>
> Thanks,
> Tiezhu

The build warning still exists when build the latest Linux 6.1-rc3 on
LoongArch, if you are OK with this change, please apply it through your
mm tree, thank you.

"If you cannot find a maintainer for the subsystem you are working on,
Andrew Morton (akpm@...ux-foundation.org) serves as a maintainer of
last resort."
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Thanks,
Tiezhu