linux-kernel - Re: [PATCH v1 1/1] platform/x86: p2sb: Don't fail if unknown CPU is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2VKWJlFvixnFu/p@smile.fi.intel.com>
Date:   Fri, 4 Nov 2022 19:22:32 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Limonciello, Mario" <Mario.Limonciello@....com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Gross <markgross@...nel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86: p2sb: Don't fail if unknown CPU is
 found

On Fri, Nov 04, 2022 at 03:58:22PM +0000, Limonciello, Mario wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Friday, November 4, 2022 10:49

...

> > We have accessing P2SB from a very few places for quite known hardware.
> > 
> > When a new SoC appears in intel-family.h it's not obvious that it needs
> > to be added to p2sb.c as well. Instead, provide default BDF and refactor
> > p2sb_get_devfn() to always succeed. If in the future we would need to
> > exclude something, we may add a list of unsupported IDs.
> > 
> > Without this change the iTCO on Intel Commet Lake SoCs became
> 
> Isn't it "Comet Lake"?

Right, thanks!

In any case I would like to have Jarkko's Tested-by before proceeding with
this. Hence v2 is warranted to appear.

> > unavailable:
> > 
> >   i801_smbus 0000:00:1f.4: failed to create iTCO device

-- 
With Best Regards,
Andy Shevchenko