linux-kernel - [RFC PATCH v2 0/2] can: virtio: virtio-can driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  4 Nov 2022 18:24:19 +0100
From:   Harald Mommer <Harald.Mommer@...nsynergy.com>
To:     virtio-dev@...ts.oasis-open.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Dariusz Stojaczyk <Dariusz.Stojaczyk@...nsynergy.com>
Subject: [RFC PATCH v2 0/2] can: virtio: virtio-can driver

Hello,

this is a new virtio-can driver. 

The proposed addition to the virtio specification which should match
this driver has been sent 25-Aug-2022 and can be found here:

https://lore.kernel.org/all/20220825133410.18367-1-harald.mommer@opensynergy.com/

(Got no comments on the updated specification proposal now.)

The RFC driver version has been sent 25-Aug-2022 and can be found here:

https://lore.kernel.org/all/20220825134449.18803-1-harald.mommer@opensynergy.com/

- Small update to be compilable against newest kernel

  - netif_napi_add() prototype change

- Address the review comments got from Arnd Bergmann, Oliver Hartkopp,
  Marc Kleine-Budde:

  - Remove virtio_can_hexdump()
  - Use completion instead of polling
  - Restructure usage of spinlock in virtio_can_start_xmit()
  - Save kicks in virtio_can_start_xmit()
  - Minimize usage of BUG_ON()
  - Make driver less noisy
  - Move register_virtio_candev() down in code
  - Remove unwanted MISRA habits used to in a former life
  - Treat bitmasks as bitmasks
  - Remove excessive usage of netdev_warn() silently sanitizing
  - Fix RTR frame handling with payload != 0
  - Work through checkpatch problems
  - Clarify license
  - Remove some pointless leftover comments

Regards
Harald